-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: use EncodeKey to encode groupkey in StreamAggExec (#49974) #50027
executor: use EncodeKey to encode groupkey in StreamAggExec (#49974) #50027
Conversation
d843b13
to
c9b8e0e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #50027 +/- ##
================================================
Coverage ? 71.9687%
================================================
Files ? 1400
Lines ? 406585
Branches ? 0
================================================
Hits ? 292614
Misses ? 94269
Partials ? 19702
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #49974
What problem does this PR solve?
Issue Number: close #49902
Problem Summary:
What changed and how does it work?
Use
EncodeKey
function to encode thegroupkey
withinStreamAggExec
. This approach is necessary as it considers collation when aggregating the result.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.