Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix reverse function on bit type column #50146

Merged
merged 10 commits into from
Feb 5, 2024

Conversation

jiyfhust
Copy link
Contributor

@jiyfhust jiyfhust commented Jan 6, 2024

What problem does this PR solve?

Issue Number: close #49566, close #50850, close #50855

Problem Summary:

What changed and how does it work?

  1. Call Coercibility
  2. Above will set default Coercibility
  3. Check CoercibilityNumeric and reset Collation
  4. Then IsBinaryStr will return false, error occurs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2024
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Jan 6, 2024

/ok-to-test

Copy link

tiprow bot commented Jan 6, 2024

Hi @jiyfhust. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 6, 2024
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Merging #50146 (8e4db6e) into master (b289dc9) will increase coverage by 2.2401%.
Report is 22 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50146        +/-   ##
================================================
+ Coverage   72.3112%   74.5514%   +2.2401%     
================================================
  Files          1466       1462         -4     
  Lines        361114     425446     +64332     
================================================
+ Hits         261126     317176     +56050     
- Misses        80777      88418      +7641     
- Partials      19211      19852       +641     
Flag Coverage Δ
integration 49.5706% <100.0000%> (?)
tiprow_ft ?
unit 70.2652% <81.8181%> (-1.9271%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0269% <ø> (-2.4502%) ⬇️
parser ∅ <ø> (∅)
br 56.6029% <ø> (+10.3018%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Jan 6, 2024
@jiyfhust jiyfhust changed the title executor: fix reverse function on bit type column expression: fix reverse function on bit type column Jan 19, 2024
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Feb 1, 2024

/test pull-integration-ddl-test

Copy link

tiprow bot commented Feb 1, 2024

@jiyfhust: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tidb_parser_test
  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test pull-integration-ddl-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyfhust
Copy link
Contributor Author

jiyfhust commented Feb 1, 2024

Could you take a look at this pr? Thx. @YangKeao @lcwangchao

@YangKeao YangKeao self-requested a review February 1, 2024 04:22
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Feb 1, 2024

/retest

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2024
@jiyfhust
Copy link
Contributor Author

jiyfhust commented Feb 2, 2024

/cc @zanmato1984
PTAL

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Feb 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 5, 2024
Copy link

ti-chi-bot bot commented Feb 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 04:57:59.136441652 +0000 UTC m=+1714320.700739357: ☑️ agreed by YangKeao.
  • 2024-02-05 04:10:30.437342646 +0000 UTC m=+157156.004112535: ☑️ agreed by zanmato1984.

@zanmato1984
Copy link
Contributor

@jiyfhust Thanks for your contribution!

@ti-chi-bot ti-chi-bot bot merged commit aa00ae2 into pingcap:master Feb 5, 2024
23 checks passed
@jiyfhust jiyfhust deleted the fix_reverse_bit branch February 6, 2024 01:06
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 19, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51130.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51131.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 19, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51132.

ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants