disttask/ddl: fix hang when reverting

[ywqzzy]

What problem does this PR solve?

Issue Number: ref #50307

Problem Summary:
Revert process run forever since we didn't mark failed revert subtask as revert_failed.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ywqzzy. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/disttask/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tiprow]

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #50357 (417d075) into master (c1eb8ab) will decrease coverage by 16.4191%.
Report is 1 commits behind head on master.
The diff coverage is 82.3529%.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #50357         +/-   ##
=================================================
- Coverage   70.0552%   53.6361%   -16.4192%     
=================================================
  Files          1444       1553        +109     
  Lines        419997     586677     +166680     
=================================================
+ Hits         294230     314671      +20441     
- Misses       105464     248095     +142631     
- Partials      20303      23911       +3608     

Flag	Coverage Δ
integration	21.6577% <82.3529%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	54.0269% <ø> (ø)
parser	∅ <ø> (∅)
br	55.6086% <ø> (+5.9147%)	⬆️

[D3Hunter]

shouldn't we fix the case that disttask is still reverting, but ddl mark it as rollback done?

it's ok for reverting task to take slots, as it's transient normally

[ywqzzy]

I am working on it

[ywqzzy]

Remove it since we will remove all reverting logic

[D3Hunter]

Revert process run forever since we didn't mark failed revert subtask as revert_failed.

if we have revert_failed subtask, task need to be this state too. but i don't think we should maintain it

maybe we can fix the Init fail in below part, so current framework logic can keep working

tidb/pkg/ddl/backfilling_dist_executor.go

Line 147 in 095227d

return errors.Trace(errors.Errorf("index info not found: %d", bgm.EleIDs[0]))

[ywqzzy]

Revert process run forever since we didn't mark failed revert subtask as revert_failed.

if we have revert_failed subtask, task need to be this state too. but i don't think we should maintain it

maybe we can fix the Init fail in below part, so current framework logic can keep working

tidb/pkg/ddl/backfilling_dist_executor.go

Line 147 in 095227d

return errors.Trace(errors.Errorf("index info not found: %d", bgm.EleIDs[0]))

Just a tmp fix for previous version of tidb, we can fire another pr to remove reverting process completely.

[ti-chi-bot]

@ywqzzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev	417d075	link	true	/test check-dev
idc-jenkins-ci-tidb/unit-test	417d075	link	true	/test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ywqzzy]

close as we have better approch