Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importinto: fix checksum always use default distsql-scan-concurrency #50807

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #50805

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    check adjust concurrency works
[2024/01/30 12:31:29.634 +08:00] [INFO] [table_import.go:933] ["checksum with adjusted distsql scan concurrency"] [concurrency=50]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2024
Copy link

tiprow bot commented Jan 30, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/check-issue-triage-complete

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Merging #50807 (3ca4701) into master (7087f70) will increase coverage by 2.1306%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #50807        +/-   ##
================================================
+ Coverage   70.5545%   72.6851%   +2.1306%     
================================================
  Files          1465       1465                
  Lines        433455     433786       +331     
================================================
+ Hits         305822     315298      +9476     
+ Misses       108436      98651      -9785     
- Partials      19197      19837       +640     
Flag Coverage Δ
integration 49.0825% <100.0000%> (?)
unit 70.3433% <100.0000%> (-0.0296%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (ø)
parser ∅ <ø> (∅)
br 51.2605% <ø> (+5.4916%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jan 30, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 30, 2024
Copy link

ti-chi-bot bot commented Jan 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-30 04:50:25.221804428 +0000 UTC m=+1454666.786102125: ☑️ agreed by lance6716.
  • 2024-01-30 06:00:21.565986662 +0000 UTC m=+1458863.130284367: ☑️ agreed by Benjamin2037.

@ti-chi-bot ti-chi-bot bot merged commit fdb13d1 into pingcap:master Jan 30, 2024
23 checks passed
@D3Hunter D3Hunter deleted the hornor-dist-concurr branch January 30, 2024 06:33
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #50815.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 30, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distsql-scan-concurrency cannot be configured when checksum for IMPORT INTO
4 participants