Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: forbid create Generated column with Grouping function (#49930) #51092

Closed
wants to merge 1 commit into from
Closed

ddl: forbid create Generated column with Grouping function (#49930) #51092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ddl/generated_column.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ type illegalFunctionChecker struct {
func (c *illegalFunctionChecker) Enter(inNode ast.Node) (outNode ast.Node, skipChildren bool) {
switch node := inNode.(type) {
case *ast.FuncCallExpr:
// Grouping function is not allowed, issue #49909.
if node.FnName.L == ast.Grouping {
c.hasAggFunc = true
return inNode, true
}
// Blocked functions & non-builtin functions is not allowed
_, IsFunctionBlocked := expression.IllegalFunctions4GeneratedColumns[node.FnName.L]
if IsFunctionBlocked || !expression.IsFunctionSupported(node.FnName.L) {
Expand Down
Loading
Loading