-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logutil: adapt new redact functions #51642
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Hi @xhebox. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: xhe <xw897002528@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better follow the comments. Reset LGTM
Co-authored-by: Hangjie Mo <mohangjie1995@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51642 +/- ##
================================================
+ Coverage 70.7416% 72.8081% +2.0665%
================================================
Files 1473 1473
Lines 436996 437020 +24
================================================
+ Hits 309138 318186 +9048
+ Misses 108525 98849 -9676
- Partials 19333 19985 +652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Defined2014, easonn7, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test mysql-test |
@xhebox: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@xhebox: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@xhebox: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test mysql-test |
@xhebox: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: close #51641, close #51310
Problem Summary: Add
redact.Stringer
, and remove all usage of old redact var to the new one for logutil reporter.redact.Redact()
renamed toredact.String()
.It also updated errors library to use the new redact function, ref #51310.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.