Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update pingcap/errors version #51854

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 18, 2024

What problem does this PR solve?

Issue Number: close #53517

Problem Summary:

What changed and how does it work?

update version to add this fix HasStack return true on empty stack to allow upper layer add stack again

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    only changed pkg/util/misc.go, existing cases should be enough to cover it

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2024
Copy link

tiprow bot commented Mar 18, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter D3Hunter added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 18, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2024
Copy link

ti-chi-bot bot commented Mar 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-18 07:24:22.840746984 +0000 UTC m=+1275089.862993372: ☑️ agreed by Benjamin2037.
  • 2024-03-18 07:26:28.669621139 +0000 UTC m=+1275215.691867526: ☑️ agreed by lance6716.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Mar 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Merging #51854 (3fd4360) into master (5a2b8e8) will decrease coverage by 16.0154%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51854         +/-   ##
=================================================
- Coverage   70.7104%   54.6951%   -16.0154%     
=================================================
  Files          1477       1588        +111     
  Lines        438429     608400     +169971     
=================================================
+ Hits         310015     332765      +22750     
- Misses       108992     252427     +143435     
- Partials      19422      23208       +3786     
Flag Coverage Δ
integration 36.6586% <100.0000%> (?)
unit 70.4382% <100.0000%> (-0.0738%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5125% <ø> (+5.6532%) ⬆️

@D3Hunter
Copy link
Contributor Author

/test all

@D3Hunter
Copy link
Contributor Author

/fast_test_tiprow

Copy link

tiprow bot commented Mar 18, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@D3Hunter
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 18, 2024
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit c5359ca into pingcap:master Mar 18, 2024
23 checks passed
@D3Hunter D3Hunter deleted the update-errors branch March 18, 2024 13:05
@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 24, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #53526.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 24, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-7.5 branch bump https://github.com/pingcap/errors to the latest commit hash
5 participants