Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: Add a RU(max) panel to observe maximum resource consumption #52007

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Mar 21, 2024

What problem does this PR solve?

Issue Number: ref #49318

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image

  • No need to test
    • I checked and no code files have been changed.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #52007 (4940d86) into master (5e19822) will decrease coverage by 17.8275%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #52007         +/-   ##
=================================================
- Coverage   72.4893%   54.6618%   -17.8275%     
=================================================
  Files          1481       1592        +111     
  Lines        365295     608788     +243493     
=================================================
+ Hits         264800     332775      +67975     
- Misses        81009     252825     +171816     
- Partials      19486      23188       +3702     
Flag Coverage Δ
integration 36.5950% <ø> (?)
unit 70.4364% <ø> (-1.9428%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 51.4667% <ø> (+5.0589%) ⬆️

"dashLength": 10,
"dashes": false,
"datasource": "${DS_TEST-CLUSTER}",
"description": "The total request unit cost for all resource groups.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "The total request unit cost for all resource groups.",
"description": "The max request unit cost per second for all resource groups.",

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 22, 2024
Copy link

ti-chi-bot bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CabinfeverB, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 22, 2024
Copy link

ti-chi-bot bot commented Mar 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-22 03:53:45.420703513 +0000 UTC m=+1608052.442949903: ☑️ agreed by glorv.
  • 2024-03-22 08:05:46.85168418 +0000 UTC m=+1623173.873930569: ☑️ agreed by CabinfeverB.

@ti-chi-bot ti-chi-bot bot merged commit 69fa424 into pingcap:master Mar 22, 2024
23 checks passed
@nolouch nolouch deleted the update-ru-max branch April 1, 2024 09:09
@nolouch nolouch added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Apr 1, 2024
@nolouch
Copy link
Member Author

nolouch commented Apr 1, 2024

/run-cherry-pick

@nolouch
Copy link
Member Author

nolouch commented Apr 1, 2024

/run-cherry-picker

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #52287.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 1, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #52288.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 1, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants