Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: apply rule_partition_pruning when optimizing CTE under static mode (#51903) #52148

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #51903

What problem does this PR solve?

Issue Number: close #51873

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-8.0 labels Mar 27, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-51903-to-release-8.0 branch from 3d7f490 to dcfdeb3 Compare March 27, 2024 08:38
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2024
Copy link

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 08:39:06.263454735 +0000 UTC m=+2057173.285701139: ☑️ agreed by qw4990.
  • 2024-03-27 08:42:35.09207633 +0000 UTC m=+2057382.114322717: ☑️ agreed by winoros.

@qw4990
Copy link
Contributor

qw4990 commented Mar 27, 2024

/test check-dev

Copy link

tiprow bot commented Mar 27, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-8.0

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-8.0@c5dc6c5). Click here to learn what that means.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.0     #52148   +/-   ##
================================================
  Coverage               ?   70.6576%           
================================================
  Files                  ?       1477           
  Lines                  ?     438360           
  Branches               ?          0           
================================================
  Hits                   ?     309735           
  Misses                 ?     109165           
  Partials               ?      19460           
Flag Coverage Δ
unit 70.4490% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 45.8103% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 43cf9a2 into pingcap:release-8.0 Mar 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants