-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: make tablesample work under different partition prune modes #52405
executor: make tablesample work under different partition prune modes #52405
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52405 +/- ##
================================================
+ Coverage 74.1411% 76.4031% +2.2620%
================================================
Files 1467 1493 +26
Lines 354227 449476 +95249
================================================
+ Hits 262628 343414 +80786
- Misses 72389 85252 +12863
- Partials 19210 20810 +1600
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@qw4990: Your lgtm message is repeated, so it is ignored. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #52282
Problem Summary:
When
tidb_partition_prune_mode
isstatic
, TiDB uses a separate operator to union results from different partitions. Buttablesample
always collects samples from all partitions, the result may contains duplicated rows.What changed and how does it work?
Pass
physicalTableID
toTableSampleExecutor
, now it only collect samples from corresponding partitions.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.