Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix missing access conds when a partial path is dual path when query involves mv index #52414

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #52395

Problem Summary:

Please see the issue and the comments in the code.

What changed and how does it work?

Add the missing accessFilters when the partial path is a dual path.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Merging #52414 (e4c36f6) into master (c39d79f) will increase coverage by 0.2032%.
Report is 7 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #52414        +/-   ##
================================================
+ Coverage   74.1210%   74.3243%   +0.2032%     
================================================
  Files          1467       1467                
  Lines        354273     427234     +72961     
================================================
+ Hits         262591     317539     +54948     
- Misses        72444      89821     +17377     
- Partials      19238      19874       +636     
Flag Coverage Δ
integration 48.7362% <100.0000%> (?)
unit 70.9753% <50.0000%> (-1.9038%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 49.5378% <ø> (+7.0999%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2024
Copy link

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 03:18:49.750130584 +0000 UTC m=+932391.277671129: ☑️ agreed by AilinKid.
  • 2024-04-09 06:35:46.128908229 +0000 UTC m=+944207.656448775: ☑️ agreed by qw4990.

@time-and-fate
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit da775f6 into pingcap:master Apr 9, 2024
23 checks passed
@time-and-fate
Copy link
Member Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@time-and-fate: new pull request created to branch release-8.1: #52448.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect query result using multi-value index
4 participants