statistics: upgrade stats timeout checkpoint after it timeouts #52424
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52424 +/- ##
================================================
+ Coverage 72.1823% 74.3340% +2.1516%
================================================
Files 1467 1467
Lines 426895 426935 +40
================================================
+ Hits 308143 317358 +9215
+ Misses 99565 89735 -9830
- Partials 19187 19842 +655
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
size/S
|
/approve |
ti-chi-bot
added
the
needs-cherry-pick-release-7.5
| @@ -1307,7 +1307,7 @@ type SessionVars struct { | |||
| ReadConsistency ReadConsistencyLevel | |||
|
|
|||
| // StatsLoadSyncWait indicates how long to wait for stats load before timeout. | |||
| StatsLoadSyncWait int64 | |||
| StatsLoadSyncWait atomic.Int64 | |||
There was a problem hiding this comment.
Update it to resolve the data race problem.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, easonn7, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
| @@ -396,7 +397,7 @@ func (*statsSyncLoad) readStatsForOneItem(sctx sessionctx.Context, item model.Ta | |||
| } | |||
|
|
|||
| // drainColTask will hang until a column task can return, and either task or error will be returned. | |||
| func (s *statsSyncLoad) drainColTask(exit chan struct{}) (*statstypes.NeededItemTask, error) { | |||
| func (s *statsSyncLoad) drainColTask(sctx sessionctx.Context, exit chan struct{}) (*statstypes.NeededItemTask, error) { | |||
There was a problem hiding this comment.
pass the limited scope arg is appreciated
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
/cherrypick release-7.1 |
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #52425
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.