Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: refactor the BaseExecutor in IndexReaderExecutor #53138

Closed
wants to merge 1 commit into from

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented May 9, 2024

What problem does this PR solve?

Issue Number: close #53136

Previously, the IndexReaderExecutor depends on a whole session context.

Problem Summary:

What changed and how does it work?

This PR removes the BaseExecutor (which provides the method to access the whole session context) and use the BaseExecutorV2 instead, which is safe to be cloned. Also this PR adds a new indexReaderExecutorContext like the existing tableReaderExecutorContext, and use it to collect all fields needed by the

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.
      It should be covered by existing tests. Didn't change the code logic.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 9, 2024
Copy link

ti-chi-bot bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yangkeao, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2024
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.6316%. Comparing base (788d505) to head (200f5c5).
Report is 541 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53138        +/-   ##
================================================
+ Coverage   74.4098%   74.6316%   +0.2218%     
================================================
  Files          1490       1491         +1     
  Lines        356051     432634     +76583     
================================================
+ Hits         264937     322882     +57945     
- Misses        71835      89784     +17949     
- Partials      19279      19968       +689     
Flag Coverage Δ
integration 49.0721% <91.8032%> (?)
unit 71.2431% <93.4426%> (-1.9293%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 50.3020% <ø> (+7.4135%) ⬆️

@YangKeao
Copy link
Member Author

YangKeao commented May 9, 2024

/retest

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2024
Copy link

ti-chi-bot bot commented Jul 22, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangKeao YangKeao closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the BaseExecutor in IndexReaderExecutor.
1 participant