-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: separate the restore client #53197
Conversation
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Hi @Leavrth. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53197 +/- ##
================================================
+ Coverage 72.5147% 74.1922% +1.6775%
================================================
Files 1498 1545 +47
Lines 429925 442418 +12493
================================================
+ Hits 311759 328240 +16481
+ Misses 98883 93392 -5491
- Partials 19283 20786 +1503
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
Signed-off-by: Jianjun Liao <jianjun.liao@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new directory structure looks good to me. Hopefully we haven't modify and logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, lance6716, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
What problem does this PR solve?
Issue Number: ref #52877
Problem Summary:
enhancement: make the restore code structure more readable.
What changed and how does it work?
Separate the snap restore client and log restore client. And remove the FineGrained configure in the internal code.
Mostly modifies are code movements, and there are some code optimization:
(* br/pkg/restore/snap_client.SnapClient).CreateDatabases
is moved into(* br/pkg/restore/internal/prealloc_db.DB).CreateDatabases
. Make the function be the same as(* DB).CreateTable
withsupportPolicy
andpolicyMap
.brContextManager
/ImportModeSwitcher
to move some functions out from br/pkg/restore/snap_client.SnapClient.multi-ingest-not-support
method, and just return error if not support multi ingest.--granularity
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.