-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix wrong behavior for = all() (#52801) #53258
planner: fix wrong behavior for = all() (#52801) #53258
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53258 +/- ##
================================================
Coverage ? 71.1396%
================================================
Files ? 1465
Lines ? 421229
Branches ? 0
================================================
Hits ? 299661
Misses ? 101078
Partials ? 20490
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This is an automated cherry-pick of #52801
What problem does this PR solve?
Issue Number: close #52755
Problem Summary:
What changed and how does it work?
Use
max
function instead offirst_row
function.if the query is
t.id = all (select s.id from s)
, it will be rewrote tot.id = (select s.id from s having count(distinct s.id) <= 1 and [all checker])
.If there is NULL in the
s.id
column, s.id should be the value that isn't null in condition t.id == s.id. So use function max to filter NULL.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.