-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoid_service: remove the force rebase on close behavior #53315
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53315 +/- ##
================================================
+ Coverage 72.4973% 74.5497% +2.0523%
================================================
Files 1497 1497
Lines 429959 429984 +25
================================================
+ Hits 311709 320552 +8843
+ Misses 98996 89535 -9461
- Partials 19254 19897 +643
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, Defined2014 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #38442
close #53393
Problem Summary:
What changed and how does it work?
The original design is that we try our best to avoid holes in AUTO_ID_CACHE=1,
so when autoid leader exit, forceRebase is called to return the non-consumed in memory IDs back.
When there are a lot of tables, this operation could not be finish quickly.
And tidb graceful shutdown can not done within 30s. This cause tidb can not restart quickly to provide service.
We think over it and deside to remove the force rebase on close behavior.
Check List
Tests
No unit test apply here (it requires tidb restart to cover the changes).
Some integration test may notice the change.
Side effects
Documentation
Behavior change, not tidb restart can cause hole in auto id allocating using AUTO_ID_CACHE=1
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.