-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: collect all columns meta by sync load (#53137) #53462
planner: collect all columns meta by sync load (#53137) #53462
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -178,7 +178,25 @@ func (c *columnStatsUsageCollector) addHistNeededColumns(ds *DataSource) { | |||
columns := expression.ExtractColumnsFromExpressions(c.cols[:0], ds.pushedDownConds, nil) | |||
for _, col := range columns { | |||
tblColID := model.TableItemID{TableID: ds.physicalTableID, ID: col.ID, IsIndex: false} | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the confliction.
It doesn't have to fix it in v7.5. This problem is related to #47496. It only affords to v8.1. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #53137
What problem does this PR solve?
Issue Number: close #53141
Problem Summary:
What changed and how does it work?
In calculating cost, we need all columns' stats to get row size.
To get right result,so we need to load all stats when to sync load.
But here is a bug.
ds.Columns
has been pruned. it doesn't contain all columns.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.