-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ranger: handle float/integers overflow properly (#53501) #53524
ranger: handle float/integers overflow properly (#53501) #53524
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
fb0d0c8
to
b1f49a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #53524 +/- ##
================================================
Coverage ? 72.7497%
================================================
Files ? 1466
Lines ? 437303
Branches ? 0
================================================
Hits ? 318137
Misses ? 98768
Partials ? 20398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #53501
What problem does this PR solve?
Issue Number: close #46538
ref #50489
Problem Summary:
What changed and how does it work?
float/integers would be returned if overflow error occurs, so convertPoint would adjust the excl of the boundary accordingly, and impossible ranges would be removed by consequent validIntervals().
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.