-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM]dumpling: Support check keyspace in dumpling #53541
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Hi @ystaticy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53541 +/- ##
================================================
+ Coverage 74.3925% 74.5009% +0.1083%
================================================
Files 1505 1505
Lines 357314 430737 +73423
================================================
+ Hits 265815 320903 +55088
- Misses 72175 89930 +17755
- Partials 19324 19904 +580
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-test |
@ystaticy: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: ref #53542
Problem Summary:
What changed and how does it work?
Check that the keyspace name is consistent between the command line and TiDB.
If they are not equal, panic dumpling task and return panic msg
panic: the keyspace name in command line is different from keyspace name in TiDB.
Check List
Tests
keyspace-name=ks1
.--keyspace-name ks1
, connect to tidb01, dumpling task will success.We can see log:
--keyspace-name ks2
, connect to tidb01, dumpling task will failed.dumpling will return
the keyspace name in command line is different from keyspace name in TiDB
.--keyspace-name
, connect to tidb01, dumpling task will failed.start TiDB instance tidb02 without
keyspace-name
start dumpling without
--keyspace-name
, connect to tidb02, dumpling task will success.start dumpling with
--keyspace-name ks1
, connect to tidb02, dumpling task will failed.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.