variable: support tidb_schema_cache_size reasonable range

[lilinghai]

What problem does this PR solve?

Issue Number: close #54034

Problem Summary:

What changed and how does it work?

The value range is 0 and [536870912, 9223372036854775807] in bytes. The size format with the units "KB|MB|GB|TB" is supported.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lilinghai. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.2965%. Comparing base (1368bf7) to head (646b75e).
Report is 20 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54035         +/-   ##
=================================================
- Coverage   72.8706%   56.2965%   -16.5742%     
=================================================
  Files          1521       1643        +122     
  Lines        435164     613659     +178495     
=================================================
+ Hits         317107     345469      +28362     
- Misses        98499     245061     +146562     
- Partials      19558      23129       +3571     

Flag	Coverage Δ
integration	36.9929% <66.6666%> (?)
unit	72.0672% <91.6666%> (+0.2001%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.3741% <ø> (+6.2353%)	⬆️

[lilinghai]

/retest

[tiprow]

@lilinghai: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[wjhuang2016]

Please test 512MB-1 and MaxValue + 1

[lilinghai]

added

[wjhuang2016]

We can get the text from SchemaCacheSize like we have done for TiDBServerMemoryLimitSessMinSize

[lilinghai]

This value is used to store the content set by the user. For example, if the user sets 1GB, then the display for user queries will also be 1GB, not 1,073,741,824. However, the TiDBServerMemoryLimitSessMinSize will display the value as an integer to the user.

mysql> set @@global.tidb_server_memory_limit_sess_min_size='1GB';
Query OK, 0 rows affected (0.01 sec)

mysql> select @@global.tidb_server_memory_limit_sess_min_size;
+-------------------------------------------------+
| @@global.tidb_server_memory_limit_sess_min_size |
+-------------------------------------------------+
| 1073741824                                      |
+-------------------------------------------------+
1 row in set (0.00 sec)

mysql> set @@global.tidb_schema_cache_size='1GB';
Query OK, 0 rows affected (0.00 sec)

mysql> select @@global.tidb_schema_cache_size;
+---------------------------------+
| @@global.tidb_schema_cache_size |
+---------------------------------+
| 1GB                             |
+---------------------------------+
1 row in set (0.00 sec)

simlar to tidb_server_memory_limit

mysql> set @@global.tidb_server_memory_limit='1GB';
Query OK, 0 rows affected (0.06 sec)

mysql> select @@global.tidb_server_memory_limit;
+-----------------------------------+
| @@global.tidb_server_memory_limit |
+-----------------------------------+
| 1GB                               |
+-----------------------------------+
1 row in set (0.00 sec)

[lilinghai]

/test unit-test

[tiprow]

@lilinghai: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[lance6716]

rest lgtm

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-06-25 02:40:16.188104697 +0000 UTC m=+687342.673593529: ☑️ agreed by wjhuang2016.
• 2024-06-26 04:43:26.065479051 +0000 UTC m=+781132.550967884: ☑️ agreed by lance6716.

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance6716,wjhuang2016]
• pkg/infoschema/OWNERS [wjhuang2016]
• pkg/sessionctx/variable/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment