*: support memTracker.detach for HashJoin, Apply and IndexLookUp in Close func #54095
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
do-not-merge/needs-tests-checked
release-note-none
|
Hi @XuHuaiyu. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ti-chi-bot
bot
added
release-note
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
|
@XuHuaiyu: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
pkg/executor/distsql.go
Outdated
| @@ -859,6 +859,7 @@ func (e *IndexLookUpExecutor) Close() error { | |||
| e.tblWorkerWg.Wait() | |||
| e.finished = nil | |||
| e.workerStarted = false | |||
| e.memTracker.Detach() | |||
There was a problem hiding this comment.
move before workerFinished
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54095 +/- ##
=================================================
- Coverage 72.8288% 56.1402% -16.6887%
=================================================
Files 1523 1643 +120
Lines 435300 607958 +172658
=================================================
+ Hits 317024 341309 +24285
- Misses 98685 243295 +144610
- Partials 19591 23354 +3763
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -45,6 +45,18 @@ type RowPtr struct { | |||
| RowIdx uint32 | |||
| } | |||
|
|
|||
| // NewListWithMemTracker creates a new List with field types, init chunk size, max chunk size and memory tracker. | |||
| func NewListWithMemTracker(fieldTypes []*types.FieldType, initChunkSize, maxChunkSize int, tracker *memory.Tracker) *List { | |||
| l := &List{ | |||
There was a problem hiding this comment.
maybe call NewList() then put trackers into it.
|
other lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guo-shaoge, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuHuaiyu
added
needs-cherry-pick-release-6.5
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
removed
the
needs-cherry-pick-release-6.1
What problem does this PR solve?
Issue Number: close #54005
Problem Summary:
What changed and how does it work?
Before:
After:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.