planner: remove meaningless pointer receiver member function of logical join.

[AilinKid]

What problem does this PR solve?

Issue Number: ref #51664, ref #52714

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @AilinKid. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/planner/OWNERS [hawkingrei,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-10 09:26:46.546710981 +0000 UTC m=+436103.781945106: ☑️ agreed by hawkingrei.
• 2024-07-10 09:27:15.487318253 +0000 UTC m=+436132.722552361: ☑️ agreed by qw4990.

[AilinKid]

/test mysql-test

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.0327%. Comparing base (20168ba) to head (f4bd74f).
Report is 4 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54550         +/-   ##
=================================================
- Coverage   72.8260%   56.0327%   -16.7934%     
=================================================
  Files          1548       1669        +121     
  Lines        436242     608848     +172606     
=================================================
+ Hits         317698     341154      +23456     
- Misses        98981     244369     +145388     
- Partials      19563      23325       +3762     

Flag	Coverage Δ
integration	37.2359% <100.0000%> (?)
unit	71.8539% <33.3333%> (-0.0033%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.6004% <ø> (+6.7089%)	⬆️

[hawkingrei]

/retest

[AilinKid]

/test check-dev2

[tiprow]

@AilinKid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.