Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix a bug in decimal multiplication (#7208) #7212

Merged
merged 1 commit into from
Jul 31, 2018
Merged

types: fix a bug in decimal multiplication (#7208) #7212

merged 1 commit into from
Jul 31, 2018

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jul 31, 2018

What have you changed? (mandatory)

Cherry-pick from #7208

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

UT

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

NO

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

YES

fix a bug in decimal multiplication.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winkyao winkyao added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. type/2.0 cherry-pick release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 31, 2018
Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli
Copy link
Member

shenli commented Jul 31, 2018

@lysu @coocood PTAL

@zhexuany
Copy link
Contributor

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit e05e983 into pingcap:release-2.0 Jul 31, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch July 31, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants