Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: fix a bug in decimal modulo operation (#7113) #7245

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

coocood
Copy link
Member

@coocood coocood commented Aug 2, 2018

Cherr-pick #7113

What have you changed? (mandatory)

fix a bug in decimal modulo operation

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

Unit test

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

NO

Does this PR affect tidb-ansible update? (mandatory)

NO

Does this PR need to be added to the release notes? (mandatory)

NO

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@coocood
Copy link
Member Author

coocood commented Aug 2, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member Author

coocood commented Aug 2, 2018

/run-common-test tidb-test=release-2.0

@coocood coocood merged commit 3d19f33 into pingcap:release-2.0 Aug 2, 2018
@coocood coocood deleted the decimal-modulo-2.0 branch August 2, 2018 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants