Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix fraction part handle of current_timestamp (#7355) #7467

Merged
merged 1 commit into from
Aug 23, 2018
Merged

expression: fix fraction part handle of current_timestamp (#7355) #7467

merged 1 commit into from
Aug 23, 2018

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Aug 23, 2018 •
edited
Loading

What is changed and how it works?

cherry-pick #7355

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Impl change

Side effects

  • no

Related changes

  • Need to be included in the release note

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Aug 23, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

crazycs520
crazycs520 reviewed Aug 23, 2018
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Aug 23, 2018
@ngaut ngaut merged commit d19300f into pingcap:release-2.0 Aug 23, 2018
@lysu lysu deleted the pick-current_time branch September 27, 2018 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @zz-jason @ngaut @crazycs520