Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: fix panic caused by empty histogram (#7912) #7927

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 17, 2018

What problem does this PR solve?

Cherry pick #7912

What is changed and how it works?

Cherry pick #7912

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 17, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 17, 2018

/run-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@alivxxx alivxxx added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Oct 17, 2018
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2018
@zz-jason zz-jason merged commit 3bd472c into pingcap:release-2.0 Oct 17, 2018
@alivxxx alivxxx deleted the stats-panic branch October 17, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants