Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix union statements order (#8214) #8318

Merged
merged 3 commits into from
Nov 15, 2018

Conversation

mtunique
Copy link
Contributor

cherry-pick #8214

@sre-bot
Copy link
Contributor

sre-bot commented Nov 14, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. contribution This PR is from a community contributor. sig/planner SIG: Planner type/2.0 cherry-pick labels Nov 14, 2018
@winoros
Copy link
Member

winoros commented Nov 14, 2018

FAIL: logical_plan_test.go:1428: testPlanSuite.TestUnion

logical_plan_test.go:1491:
    c.Assert(err, NotNil)
... value = nil

Please check this error.

@zz-jason
Copy link
Member

@mtunique CI failed:

FAIL: logical_plan_test.go:1428: testPlanSuite.TestUnion

logical_plan_test.go:1498:
    c.Assert(ToString(p), Equals, tt.best, comment)
... obtained string = "UnionAll{UnionAll{Dual->Projection->Dual->Projection}->Aggr(firstrow(a))->Projection->Dual->Projection}->Projection->Sort"
... expected string = "UnionAll{UnionAll{Dual->Projection->Projection->Dual->Projection->Projection}->Aggr(firstrow(a))->Projection->Dual->Projection->Projection}->Projection->Sort"
... case:5 sql:select * from (select 1 as a  union select 1 union all select 2) t order by a

@XuHuaiyu
Copy link
Contributor

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtunique
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason merged commit 464a3e6 into pingcap:release-2.0 Nov 15, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants