You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Opening a thread from search should open find on the match
#19838
Cmd+K and the sidebar search both find threads by their message text and show a snippet. Opening one of those results lands at the bottom of the thread with find closed, so you press Cmd+F and type the same query again.
Proposal: when a result matched on its messages, open the thread with Cmd+F find already open on that query. Title-only matches keep opening the thread as today.
Implementation sketch (web and desktop only, about 40 lines plus a test):
The thread route accepts an optional ?find= search param.
The command palette and sidebar search set it for content matches.
ChatView opens thread find with it once the thread's timeline is loaded, then drops it from the URL so reload or Back does not reopen find.
No server, contracts or mobile changes. Mobile has no in-thread find yet.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Cmd+K and the sidebar search both find threads by their message text and show a snippet. Opening one of those results lands at the bottom of the thread with find closed, so you press Cmd+F and type the same query again.
Proposal: when a result matched on its messages, open the thread with Cmd+F find already open on that query. Title-only matches keep opening the thread as today.
Implementation sketch (web and desktop only, about 40 lines plus a test):
?find=search param.No server, contracts or mobile changes. Mobile has no in-thread find yet.
A working branch is ready if the direction is approved: imqdee/t3code@main...feat/search-result-opens-find
All reactions