Repository navigation
Replies: 3 comments
|
One more that I think fits here - the thread details panel (the card with the machine name, Open in File Explorer, branch, PR and Changes) also ignores the Motion setting, even though it's literally a panel in the code. It's It has two forms (
Since it's a panel, I think it's kind of the clearest case for option 1, and could be a good first step - the popover form would use the panel animation duration and turn off at 0 ms / with reduced motion. I'd leave the inline form alone unless you want it to animate too. |
|
Filed a focused fix for Thread Details honoring the existing Motion setting in both its inline and popover forms: #22434 Before/after videos and screenshots are in the PR. This keeps the scope to the panel; it doesn't change the picker behavior discussed here. |
|
I'd also welcome consistent motion for these pickers. I traced the history before proposing a change:
Would maintainers approve a focused PR giving Before implementation, which timing policy fits the intended design: fixed brief popup transitions matching Popover, or connecting all 3 primitives to the existing Motion setting as proposed above? Prepared with gpt-6.1-sol in Codex through T3 Code. — Brandon Julio Thenaro |
Uh oh!
There was an error while loading. Please reload this page.
Hey! Small inconsistency I noticed on the composer - opening the model picker plays a little scale/fade animation, but the reasoning effort and access pickers just pop open. None of them are connected to Settings → Motion either, so even with panel animations at 0 ms the model picker still animates.
I looked into it a bit, and it comes from the shared primitives, not the pickers themselves:
Popover, which scales and fades every popover in and out (components/ui/popover.tsx).Menuand access usesSelect, which don't animate at all.usePanelAnimationSettings()inpanelAnimations.ts), so popovers, menus and selects never read it.prefers-reduced-motion(kind of like the collapsible gap in Verify reduced-motion behavior of shared disclosures #10255).Since
Popoveris used in ~30 places, fixing this either way changes every popover in the app, so I wanted to check which direction you'd prefer before opening a PR:Happy to do the PR for whichever one you'd pick!
All reactions