Repository navigation
Assign people to a pull request from its summary tab #26746
TonybynMp4
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The Pull Requests summary tab shows reviewers but not assignees, and T3 Code has no way to assign anyone. To hand a PR to a teammate, or take it yourself, you have to leave for GitHub or GitLab.
Proposal
Add an Assignees row to the summary tab, with a menu to add and remove people. It would work on GitHub and GitLab.
assignableUsers(query:)on GitHub,users?search=on GitLab).Assignee limits
Each host caps how many people can be assigned, and the menu follows the cap:
allowsMultipleAssignees), so the row reads "Assignee" and picking someone replaces the current one, as GitLab's UI does.Issuable::MAX_NUMBER_OF_ASSIGNEES_OR_REVIEWERS).The server refuses a list over the limit too, so the host never quietly keeps only part of it. An older GitLab that can't answer the query falls back to no limit in the menu, and the host stays the final check.
Out of scope
ghorglab. Happy to add this as a follow-up.allowsMultipleReviewers). That's a separate fix.Already built
I implemented this in #22381, which was closed for lacking prior approval. The first version was tested by hand against GitHub and a self-hosted GitLab instance. The limits and save-on-close are covered by unit tests for both hosts so far. I don't have a paid GitLab to assign on, so that path is checked only by reading the flag from gitlab.com. Names and titles are blurred below because the GitLab instance is internal. The screenshots predate the save-on-close change, which doesn't change how the menu looks.
Assign menu, current assignee first:
Typing in the menu also asks GitLab, which finds someone past the first page of 100:
The same PR also adds filtering by assignee, which I've proposed separately in #14336 (comment). The PR can be split in 2 and ship separately.
If the direction and scope work, I'll resubmit the assign part on its own.
All reactions