Repository navigation
Reconsider pnpm's global virtual store for dev worktrees: disk and delete time #26925
Closed
JustYannicc
started this conversation in
Ideas
Replies: 1 comment
|
Closing as a duplicate of #26926, which tracks the same request. Please follow along there. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
#22765 (opt-in pnpm global virtual store for dev worktrees) was closed because pnpm 12 took most of the install-speed win. That weighed install speed only. The bigger cost for agent-heavy work is disk and delete time, when one machine keeps dozens of worktrees of this repo alive at once.
We measured on macOS (APFS), warm store, one worktree each, on an isolated volume so other writes couldn't skew it:
node_modulesrm -rf node_modulesThe shared store is a one-time ~7.6 GB.
dumakes per-project stores look like ~6–7 GB each because APFS clones are counted per copy; the physical cost is the ~160 MB above, plus 372k files' worth of metadata that every delete has to walk. With ~100 worktrees, that's ~15 GB and minutes of I/O per cleanup.On the risks listed in the close: we run it unconditionally in our fork, CI included, so type resolution can't differ from CI. Vite, Metro and desktop packaging follow the store links through one shared helper.
Proposal: reconsider the global virtual store for dev worktrees, either on by default or behind the existing opt-in from #22765. If you're open to it, we'll send a focused PR scoped however you prefer.
All reactions