Repository navigation
Keyboard review for the Diff panel and the pull request Code tab #29683
cwooldridge1
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Problem
Reviewing a diff in T3 Code needs the mouse. In the Diff panel and in a pull request's Code tab, you can't step through files, mark a file viewed, find the next file you haven't read, or comment on a line from the keyboard. On a large agent change this is slow, and it's easy to lose track of what you've already read.
Proposal
Make both diff views reviewable from the keyboard. Keys work while focus is in the diff's panel and never while you type in a text field. There are three levels, and
Escsteps back one.j/knext or previous file.n/Shift+Nnext or previous unviewed file.vtoggle viewed, which also folds.Enterfold or unfold.fshow one file at a time.imove into the file's lines.j/kmove one line, leaving the file at either end.Shift+J/Shift+Kshow more unchanged lines.ccomment.Shift+Vstart a selection.vmark viewed and return to files.j/kgrow or shrink.ccomments on the selected lines.Screen.Recording.2026-11-02.at.2.50.48.PM.mov
Supporting pieces:
diff.*keybinding command, behind newdiffFocusanddiffLineModewhen-clauses.N / M viewedcount. In the Code tab these are GitHub's Viewed marks. In the Diff panel they are stored per device and thread, and a file that changes reads as unviewed again.Out of scope: mobile, syncing Diff panel viewed marks across devices, and per-hunk viewed state.
Working implementation
I've built this in #28917 to check that it's feasible and fast. Cursor moves don't re-render the diff, and stepping through files scrolls only as far as it needs to. Please treat it as a prototype for this discussion, not a request to merge as is. I'll reshape or split it however you want.
Questions for maintainers
All reactions