Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Pwm #67

Merged
merged 5 commits into from
Jan 16, 2015
Merged

New Pwm #67

merged 5 commits into from
Jan 16, 2015

Conversation

Vido
Copy link
Contributor

@Vido Vido commented Jan 16, 2015

Changes discussed on the topic: PWM pins

1) The abstractmethod decorator from _get_pwm_duty_cycle will be dropped
So the _get_pwm_duty_cycle will have a implementation. It will hold the last set value.
If some Board can probe its hardware, then this Board should overwrite this method.

2) PwmPin will recive the "frequency||period" property;
This property can be read and write.
Each board should implement its own default values.

3) PwmOutputCapable recives a new abstractmethod _set_pwm_frequency and a _get_pwm_frequency
Each driver take care of his own _set_pwm_frequency. But _get_pwm_frequency has a default implementation (hold the last set value). If a Board has a better method, this should be overwritten.

Now the value property does not call Board.
The is a interface for setting frequency in the Board
Missing _get_pwm_frequency, and the frequency property
@coveralls
Copy link

Coverage Status

Coverage increased (+1.33%) when pulling 72ed3e0 on Vido:new_pwm into b448d5e on garoa:master.

@Vido
Copy link
Contributor Author

Vido commented Jan 16, 2015

Now, we should do some onboard testing.

ramalho added a commit that referenced this pull request Jan 16, 2015
@ramalho ramalho merged commit 05ac12f into pingo-io:master Jan 16, 2015
@ramalho
Copy link
Contributor

ramalho commented Jan 16, 2015

Thanks, @Vido !

@ramalho
Copy link
Contributor

ramalho commented Jan 16, 2015

I merged your pull request. Thanks, @Vido!

Wrapping up my book in the next few weeks. Then we can have a sprint!

Cheers,

Luciano

On Fri, Jan 16, 2015 at 10:08 AM, Lucas Vido notifications@github.com
wrote:

Now, we should make some onboard testing.


Reply to this email directly or view it on GitHub
https://github.com/garoa/pingo/pull/67#issuecomment-70245209.

Luciano Ramalho
Twitter: @ramalhoorg

Professor em: http://python.pro.br
Twitter: @pythonprobr

@Vido Vido deleted the new_pwm branch January 16, 2015 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants