Back-port v3.1.0 to v2.x.x

[watson]

Closes #160

The following commits have not been back-ported:

• Replace non-native Object.assign with native
• Remove node 0.10/0.12 from travis config
• Move addLevel to an instance method
• Fix readme: static addLevel -> instance addLevel
• More readme fix
• Last readme fix?
• Do not check for node v0.10 in .travis.yml script.

The following commits have been back-ported, but slightly modified:

• deep interp perf - The template string have been replaced by String(...)
• Reorganize our one big long Readme into multiple files - The docs for addLevel uses the old pre instance docs and levelVal docs have been removed
• Add tests for err-serializer - The Object.assign calls have been rewritten and a single test omitted when running in Node.js v0.x
• Added test for the new error serializer. - The Object.assign call and ES6 shorthand property names have been rewritten

Everything else have been back-ported as is.

[mcollina]

I'm 👍 on this. @jsumners @davidmarkclements what do you think?

@watson would you be up to maintaining v2 going forward?

[watson]

@mcollina 👍

[davidmarkclements]

yeah that's awesome great stuff @watson

[jsumners]

I think if @watson really wants to maintain the branch then 👍 . Personally, I don't have any financial incentive to desire 0.10/12 compatibility and would rather just not even think about them.

[mcollina]

I propose that we publish a pino@v2 tag on NPM with this branch. @latest should still be the top-most line (currently v3).

We should also change the docs on master to note that there is a v2 line, and where the docs for that v2 line are.

Do we all agree?

[watson]

@jsumners normally I wouldn't do this, but my company unfortunately still have customers running production systems on v0.10. So in order for us to use pino, we need the v0.10 support. So for now, I see this as the only option.

[jsumners]

@mcollina that is fine with me.

[mcollina]

@watson I've added you on NPM and I have invited you to the org. Feel free to send PRs for your contacts in the README etc, also to https://github.com/pinojs/community.

You can release v2 on NPM on the @v2 tag, and not bump latest. Send PRs for the docs accordingly :).

[watson]

@mcollina @jsumners @davidmarkclements Thanks y'all 😃

[watson]

@mcollina I've accepted the invite, but I don't seem to have access to push to the v2.x.x branch

[mcollina]

@watson you should be good now.

[watson]

Hmmm - still not quite working

~pino (v2.x.x 👎 )% git push origin v2.x.x 
ERROR: Permission to pinojs/pino.git denied to watson.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I even tried to delete the local repo and clone a new one. This is my .git/config - can you spot any problem?:

[core]
	repositoryformatversion = 0
	filemode = true
	bare = false
	logallrefupdates = true
	ignorecase = true
	precomposeunicode = true
[remote "origin"]
	url = git@github.com:pinojs/pino.git
	fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
	remote = origin
	merge = refs/heads/master
[branch "v2.x.x"]
	remote = origin
	merge = refs/heads/v2.x.x

[mcollina]

@watson my bad, now it should be good.

[watson]

@mcollina works now, thanks :)

Btw, v2 is not a valid dist tag on npm. We have to chose something that can't be interpreted as a semver range:

Tags that can be interpreted as valid semver ranges will be rejected. For example, v1.4 cannot be used as a tag, because it is interpreted by semver as >=1.4.0 <1.5.0. See npm/npm#6082.

Source https://docs.npmjs.com/cli/dist-tag

[mcollina]

@watson how about legacy?

[watson]

legacy it is 👍

[watson]

Success! The v2.x.x branch is now published as v2.16.0. Install using npm install pino@legacy

[mcollina]

Can you send PRs to the README of the 3.x line, so that if someone needs v0.10 and v0.12 support, they can install @legacy?

We also use https://github.com/pinojs/pino/releases to track down each formal release, as a changelog.

[watson]

@mcollina I haven't used GitHub releases before - should I just click "Draft a new release" write v2.16.0 as the "Tag version" and "Release title" and then a short change log in the text field?

[mcollina]

Yes.

[watson]

@mcollina how do you feel about this?

[mcollina]

@watson awesome, go ahead!!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.