Make pino.destination sync

[mcollina]

Fixes #542

[mcollina]

@yonjah @brandondoran @pies @zyf0330 please test!

[zyf0330]

With this fix, I don't must need pino.final or pino.destination to output complete log followed by process.exit(), just normal pino logger.

[yonjah]

I did a few basic tests and it seem to be working with no issues

[davidmarkclements]

more comments to come in-thread

[davidmarkclements]

1. I think this means we can remove (or at least deprecate) destination.flushSync
2. In the docs we can remove https://github.com/pinojs/pino/blame/master/docs/api.md#L665-L666
3. need to adjust pino.final docs (starting: https://github.com/pinojs/pino/blame/master/docs/api.md#L703) with an intro saying ONLY FOR pino.extreme and then remove all references to pino.destination

[mcollina]

I think this means we can remove (or at least deprecate) destination.flushSync

destination and extreme are in fact the same thing, configured differently. We need it for extreme, so we get it in destination as well.

In the docs we can remove https://github.com/pinojs/pino/blame/master/docs/api.md#L665-L666

Definitely.

need to adjust pino.final docs (starting: https://github.com/pinojs/pino/blame/master/docs/api.md#L703) with an intro saying ONLY FOR pino.extreme MODE and then remove all references to pino.destination

I'll do that.

everything has been addressed

[mcollina]

@davidmarkclements @jsumners PTAL, it should be ready to land.

I've removed the lambda hack, as it should not be needed anymore.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.