Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pino.destination sync #566

Merged
merged 6 commits into from Dec 11, 2018

Conversation

@mcollina
Copy link
Member

commented Dec 9, 2018

Fixes #542

@mcollina mcollina requested review from jsumners and davidmarkclements Dec 9, 2018

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Dec 9, 2018

@zyf0330

This comment has been minimized.

Copy link

commented Dec 10, 2018

With this fix, I don't must need pino.final or pino.destination to output complete log followed by process.exit(), just normal pino logger.

@yonjah

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2018

I did a few basic tests and it seem to be working with no issues

@davidmarkclements
Copy link
Member

left a comment

more comments to come in-thread

test/final.test.js Outdated Show resolved Hide resolved
test/destination-exit.test.js Outdated Show resolved Hide resolved
@davidmarkclements

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

  1. I think this means we can remove (or at least deprecate) destination.flushSync
  2. In the docs we can remove https://github.com/pinojs/pino/blame/master/docs/api.md#L665-L666
  3. need to adjust pino.final docs (starting: https://github.com/pinojs/pino/blame/master/docs/api.md#L703) with an intro saying ONLY FOR pino.extreme and then remove all references to pino.destination
@mcollina

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2018

I think this means we can remove (or at least deprecate) destination.flushSync

destination and extreme are in fact the same thing, configured differently. We need it for extreme, so we get it in destination as well.

In the docs we can remove https://github.com/pinojs/pino/blame/master/docs/api.md#L665-L666

Definitely.

need to adjust pino.final docs (starting: https://github.com/pinojs/pino/blame/master/docs/api.md#L703) with an intro saying ONLY FOR pino.extreme MODE and then remove all references to pino.destination

I'll do that.

mcollina and others added 5 commits Dec 11, 2018
Update test/final.test.js
Co-Authored-By: mcollina <matteo.collina@gmail.com>

everything has been addressed

@mcollina

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2018

@davidmarkclements @jsumners PTAL, it should be ready to land.

I've removed the lambda hack, as it should not be needed anymore.

@davidmarkclements davidmarkclements merged commit 5233273 into master Dec 11, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@mcollina mcollina deleted the make-destination-sync branch Dec 14, 2018

tlvince added a commit to tlvince/pino that referenced this pull request Aug 14, 2019
docs(api): remove Lambda note in pino-destination
In pinojs#566, the Lambda hack was removed. Seems this was missed from the
docs. AFAICT, the [Lambda reference][1] in `pino-extreme` is still
relevant.

[1]: https://github.com/pinojs/pino/blob/43d398800fc8b0de189ccd9b11bc2afdb28524d9/docs/api.md#pinoextremetarget--sonicboom
mcollina added a commit that referenced this pull request Aug 15, 2019
docs(api): remove Lambda note in pino-destination (#697)
In #566, the Lambda hack was removed. Seems this was missed from the
docs. AFAICT, the [Lambda reference][1] in `pino-extreme` is still
relevant.

[1]: https://github.com/pinojs/pino/blob/43d398800fc8b0de189ccd9b11bc2afdb28524d9/docs/api.md#pinoextremetarget--sonicboom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.