-
Notifications
You must be signed in to change notification settings - Fork 1
fix offline use #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix offline use #12
Conversation
* recommend extension * Update to 1.0.5 * Github Action: Updated dist files * add keywords * Github Action: Updated dist files * Delete pioarduino-ide-1.0.5.vsix * Github Action: Updated dist files --------- Co-authored-by: Jason2866 <Jason2866@users.noreply.github.com> Co-authored-by: mathieucarbou <mathieucarbou@users.noreply.github.com> Co-authored-by: Jason2866 <24528715+Jason2866@users.noreply.github.com>
* fix starting install when no inet connection
Caution Review failedThe pull request is closed. WalkthroughImplements lazy loading of pioarduino-node-helpers and deferred installer stage initialization, adjusts installer check/install flow and teardown, ensures Windows terminals set UTF-8 on creation, updates a docs platform-zip URL, and bumps package version and two dependencies. Changes
Sequence Diagram(s)sequenceDiagram
participant Ext as Extension
participant IM as InstallationManager
participant Helpers as pioarduino-node-helpers
Ext->>IM: check()
IM->>IM: createStages() if null
IM->>Helpers: require('pioarduino-node-helpers')
IM->>IM: build stages
IM->>IM: iterate stages -> check
IM-->>Ext: check result / error
note over Ext: on error, log warn and return false (skip install)
Ext->>IM: install(progress) [if needed]
IM->>IM: ensure stages, run install pipeline
sequenceDiagram
participant User as User
participant Ext as Extension
participant Term as PIOTerminal
User->>Ext: trigger terminal action
Ext->>Term: sendText(text)
alt terminal missing or ended
Term->>Term: new() -> create terminal
alt Windows
Term->>Term: send "chcp 65001"
end
end
Term->>Term: send text to shell
Term-->>User: displays output
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these settings in your CodeRabbit configuration. 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
Bug Fixes
Refactor
Documentation
Chores