Skip to content

Eliminate fallback for Python environment setup #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Eliminate fallback for Python environment setup #299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions platform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,18 +740,6 @@ def setup_python_env(self, env):
# Update SCons environment with centrally configured Python executable
env.Replace(PYTHONEXE=self._penv_python)
return self._penv_python, self._esptool_path

# This should not happen, but provide fallback
logger.warning("Penv not set up in configure_default_packages, setting up now")

# Fallback to minimal setup if centralized configuration failed
config = ProjectConfig.get_instance()
core_dir = config.get("platformio", "core_dir")
penv_python, esptool_path = setup_penv_minimal(self, core_dir, install_esptool=True)
self._penv_python = penv_python
self._esptool_path = esptool_path
env.Replace(PYTHONEXE=penv_python)
return penv_python, esptool_path

def configure_default_packages(self, variables: Dict, targets: List[str]) -> Any:
"""Main configuration method with optimized package management."""
Expand Down