Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Go 1.13 and 1.14 #15

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Test on Go 1.13 and 1.14 #15

merged 2 commits into from
Mar 26, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 8, 2020

Test on Go 1.13 and 1.14

Suppress warning on Travis-CI.
@at-wat
Copy link
Member Author

at-wat commented Mar 8, 2020

Not tested yet

@at-wat
Copy link
Member Author

at-wat commented Mar 8, 2020

Configuration is valid. But seems causing test failure.

@Sean-Der
Copy link
Member

Sean-Der commented Mar 8, 2020

@at-wat Feel free to send any test failures my way! happy to split the work :)

@at-wat
Copy link
Member Author

at-wat commented Mar 8, 2020

https://travis-ci.org/pion/webrtc/builds/659740262?utm_source=github_status&utm_medium=notification
I restarted this a few times. i386 and WASM on Go 1.14 is continuously failing. I haven't seen the details yet.

@at-wat
Copy link
Member Author

at-wat commented Mar 10, 2020

One of the failure at there is TestPeerConnection_Renegotation_AddTrack.
It also fails on local Go 1.13. Seems not a Go version specific.

@Sean-Der
Copy link
Member

@at-wat this has been known to be flakey. I would disable (and I think we already have a ticket) I will work on fixing!

Would you be ok with me moving us from Travis to Github Workflows? I am want to learn it, but don't want to move if it is worse. I don't have any experience, so want to check with you first :)

@at-wat
Copy link
Member Author

at-wat commented Mar 10, 2020

The main problem of GitHub Actions for us is that it doesn't concurrently run matrix build.
Matrix build is run in series and if one target fails, remaining targets will be canceled.

Another one problem is that Action never triggers other Action to avoid endless loop.
#16 will not work if CI is run on GitHub Actions.

And, I believe that getting flaky test result on Travis-CI just means the test or library is not fully stable.
I guess main cause is load of the actual CPU. So, error on Travis may also happen on some real use cases.

@at-wat
Copy link
Member Author

at-wat commented Mar 10, 2020

pion/webrtc#1039 occurs frequently.

Goroutine leaks on WASM Go 1.14.

=== RUN   TestNewBundlePolicy
--- PASS: TestNewBundlePolicy (0.00s)
=== RUN   TestBundlePolicy_String
--- PASS: TestBundlePolicy_String (0.00s)
=== RUN   TestConfiguration_getICEServers
=== RUN   TestConfiguration_getICEServers/Success
=== RUN   TestConfiguration_getICEServers/Success#01
--- PASS: TestConfiguration_getICEServers (0.00s)
    --- PASS: TestConfiguration_getICEServers/Success (0.00s)
    --- PASS: TestConfiguration_getICEServers/Success#01 (0.00s)
=== RUN   TestDataChannel_Open
=== RUN   TestDataChannel_Open/handler_should_be_called_once
    TestDataChannel_Open/handler_should_be_called_once: util.go:37: Unexpected routines on test startup: 
        goroutine 6 [waiting]:
        runtime.gopark(0x0, 0x0, 0x0, 0x1)
        	/home/travis/go/src/runtime/proc.go:304 +0x22
        runtime.handleEvent()
        	/home/travis/go/src/runtime/lock_js.go:235 +0xf
        runtime.goexit()
        	/home/travis/go/src/runtime/asm_wasm.s:428 +0x1

It seems not a leak in our code.

@at-wat
Copy link
Member Author

at-wat commented Mar 11, 2020

All nested t.Run has runtime.goexit() routine at beginning.
pion/transport#62 will fix it.

at-wat added a commit to pion/webrtc that referenced this pull request Mar 12, 2020
@at-wat
Copy link
Member Author

at-wat commented Mar 12, 2020

It should be ready now.

@at-wat at-wat changed the title Upgrade golang Test on Go 1.13 and 1.14 Mar 20, 2020
@at-wat at-wat merged commit d0acbcb into master Mar 26, 2020
@at-wat at-wat deleted the upgrade-golang branch March 26, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants