Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.14 WASM #62

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Support Go 1.14 WASM #62

merged 1 commit into from
Mar 11, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Mar 11, 2020

Nested t.Run on Go 1.14 WASM has runtime.goexit() routine at beginning.

Reference issue

pion/.goassets#15
pion/webrtc#1066

@Sean-Der
Copy link
Member

nice find! you are killing it :)

Nested t.Run on Go 1.14 WASM has runtime.goexit() routine
at beginning.
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   82.81%   82.88%   +0.06%     
==========================================
  Files          17       19       +2     
  Lines        1554     1560       +6     
==========================================
+ Hits         1287     1293       +6     
  Misses        181      181              
  Partials       86       86              
Flag Coverage Δ
#go 82.86% <100.00%> (+0.04%) ⬆️
#wasm 80.29% <100.00%> (+0.05%) ⬆️
Impacted Files Coverage Δ
test/util.go 81.63% <100.00%> (+0.78%) ⬆️
test/util_nowasm.go 100.00% <100.00%> (ø)
test/util_wasm.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a78bab...ca0fc5d. Read the comment docs.

@at-wat at-wat merged commit 578d8b3 into master Mar 11, 2020
@at-wat at-wat deleted the support-go114-wasm branch March 11, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants