Add WithTailChecker option to depacketizer #1882
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Galene is now using its own samplebuilder, it would be good
to avoid splitting the community by having the public interfaces
diverge too much. This means preventing internal details of the
samplebuilder from leaking into other parts of Pion.
An earlier commit sneaked in the IsDetectedFinalPacketInSequence
method to the rtp.Depacketizer interface. Not only does this
break compatibility with earlier versions, it requires every single
implementation of rtp.Depacketizer to implement essentially the
same code. It is also conceptually wrong, as the job of finding
the end of the packet belongs in the samplebuilder, not in the
depacketizer.
In this commit, we treat partition ends similarly to partition
starts: we add a new callback to the samplebuilder whose role
is to determine whether a packet ends a partition. A new option
WithPartitionTailChecker, analogous to WithPartitionHeadChecker,
can be used to set that field. Tests are adapted.