Add WithTailChecker option to depacketizer #1882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1882 +/- ##
==========================================
- Coverage 75.61% 75.55% -0.06%
==========================================
Files 84 84
Lines 6049 6051 +2
==========================================
- Hits 4574 4572 -2
- Misses 1084 1088 +4
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
An earlier commit sneaked in the IsDetectedFinalPacketInSequence method to the rtp.Depacketizer interface. Not only does this break compatibility with earlier versions, it requires every single implementation of rtp.Depacketizer to implement essentially the same code. It is also conceptually wrong, as the job of finding the end of the packet belongs in the samplebuilder, not in the depacketizer. In this commit, we treat partition ends similarly to partition starts: we add a new callback to the samplebuilder whose role is to determine whether a packet ends a partition. A new option WithPartitionTailChecker, analogous to WithPartitionHeadChecker, can be used to set that field. Tests are adapted.
|
Since we have The API disagreement is unfortunate, but I think we need to stick with it until v4. @jech If you feel strongly I am in support of completely reworking the public API for |
|
@Sean-Der in that case, I suppose we move the PartitionHeadChecker into the codec too, in order to avoid having an inconsistent API. I'll see if I have time to submit a PR in time for 3.1.0. |
While Galene is now using its own samplebuilder, it would be good
to avoid splitting the community by having the public interfaces
diverge too much. This means preventing internal details of the
samplebuilder from leaking into other parts of Pion.
An earlier commit sneaked in the IsDetectedFinalPacketInSequence
method to the rtp.Depacketizer interface. Not only does this
break compatibility with earlier versions, it requires every single
implementation of rtp.Depacketizer to implement essentially the
same code. It is also conceptually wrong, as the job of finding
the end of the packet belongs in the samplebuilder, not in the
depacketizer.
In this commit, we treat partition ends similarly to partition
starts: we add a new callback to the samplebuilder whose role
is to determine whether a packet ends a partition. A new option
WithPartitionTailChecker, analogous to WithPartitionHeadChecker,
can be used to set that field. Tests are adapted.