Make the depacketizer more consistent #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes to depacketizer, partition tail checking is done in the Depacketizer, while partition tail checking is done in the PartitionHeadChecker. This is inconsistent and error-prone.
In pion/webrtc#1882, I proposed moving both methods into samplebuilder options; this was rejected, arguing that codecs should be more convenient to use. In this PR, we move both methods into Depacketizer, which obsoletes PartitionHeadCheckers.