Make the depacketizer more consistent #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jech
force-pushed
the
consistent-depacketizer
branch
from
5f9140a
to
b874c61
Compare
Codecov Report
@@ Coverage Diff @@
## v1 #150 +/- ##
=====================================
Coverage ? 93.02%
=====================================
Files ? 14
Lines ? 932
Branches ? 0
=====================================
Hits ? 867
Misses ? 46
Partials ? 19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jech
force-pushed
the
consistent-depacketizer
branch
2 times, most recently
from
8916ec9
to
5f832cd
Compare
jech
force-pushed
the
consistent-depacketizer
branch
2 times, most recently
from
e39d6ac
to
e7a5991
Compare
We used to do partition head checking in PartitionHeadChecker and partition tail checking in Depacketizer, which is confusing and error-prone. Move all checking into the Depacketizer itself.
jech
force-pushed
the
consistent-depacketizer
branch
from
e7a5991
to
806a843
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent changes to depacketizer, partition tail checking is done in the Depacketizer, while partition tail checking is done in the PartitionHeadChecker. This is inconsistent and error-prone.
In pion/webrtc#1882, I proposed moving both methods into samplebuilder options; this was rejected, arguing that codecs should be more convenient to use. In this PR, we move both methods into Depacketizer, which obsoletes PartitionHeadCheckers.