Fix for piotrmurach/issues/35 #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 19, 2021
| @@ -64,9 +68,13 @@ | |||
| ['h1', 'a1'], | |||
| ['h2', 'a2'], | |||
| ['h3', 'a3'], | |||
| ['h4', 'a4'], | |||
There was a problem hiding this comment.
Style/WordArray: Use %w or %W for an array of words.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@piotrmurach can you have a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
It fixes an issue that happens by rotating to vertical and back providing no header described at /issues/35.
Why are we doing this?
It was failing when the table size exceeds the currently set width and it defaults to vertical orientation.
Benefits
The gem will behave as expected when rotated to vertical and again when back to horizontal.
Drawbacks
None that I can foresee, but does not hurt to have a look before. Could be good to improve all specs to have further columns and different number of columns vs rows both including versions with more columns than rows and more rows than columns to check if further similar issues are found across the library.
Requirements
Put an X between brackets on each line if you have done the item:
[X] Tests written & passing locally?
[X] Code style checked?
[X] Rebased with
masterbranch?[] Documentation updated?