New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of a closing animation #90

Closed
pisi opened this Issue Dec 23, 2011 · 2 comments

Comments

Projects
None yet
1 participant
@pisi
Owner

pisi commented Dec 23, 2011

@IsraelThompson had a nice idea of having also a closing animation to complement the opening one in #49. He had some problems implementing it and might have had tapped a bug. But interesting idea indeed, let's discuss it, shall we.

Having a closing animation would expand the options API with:

  • definition of number of spins to be played back in order for the closing animation to happen,
  • definition of closing animation duration. Possibly in seconds, just like the opening option,
  • and maybe even definition of closing-specific speed to use instead of the normal speed.

All very nice. But I'm not sure about the usage scenarios. With the speed, opening and entry options , Reel already empowers you with two independent phases of animation, which both can reel in opposite directions. The first phase limited in duration and the second phase being a neverending self-resuming spin. From my point of view, by adding the closing, instead of having one duration-limited and one unlimited, we would be having three duration-limited phases.

That may look like a gain, but it's an overkill I'm afraid. What I recon instead in this issue is a need to define some sort of limit of how long the regular animation can play at once after "play" has been triggered. So that we can make the second animation phase duration-limited.

Or do we really need 3 phases when there are only 2 possible directions of playback?

@ghost ghost assigned pisi Feb 27, 2012

pisi added a commit that referenced this issue Oct 12, 2012

pisi added a commit that referenced this issue Oct 12, 2012

The mechanics of this is similar to the opening animation in that it …
…calculates how many times to tick until it should stop. Number is stored in `"ticks"` data. #90

pisi added a commit that referenced this issue Oct 12, 2012

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Oct 12, 2012

Owner

Ok, so at the end I've implemented one new option - duration - which accepts duration of animation play in seconds. When it is set, the animation will automatically stop after the given time. Triggering play event resets the duration counter and the animation will play for the given time and stop once again.

Already merged into the development branch for release in version 1.3.

Owner

pisi commented Oct 12, 2012

Ok, so at the end I've implemented one new option - duration - which accepts duration of animation play in seconds. When it is set, the animation will automatically stop after the given time. Triggering play event resets the duration counter and the animation will play for the given time and stop once again.

Already merged into the development branch for release in version 1.3.

@pisi pisi closed this Oct 12, 2012

pisi added a commit that referenced this issue Feb 20, 2013

Removed the prematurely included `duration` option. Technically, this…
… API change can not land earlier than in 1.3. Please use [gh-90-duration branch](/pisi/Reel/tree/gh-90-duration] instead if you are interested in setting up animation duration. The `duration` option there is fully working and will be released in version 1.3.

@pisi pisi reopened this Feb 23, 2013

@pisi pisi closed this Aug 29, 2013

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Nov 5, 2013

Owner

Released today as part of v1.3.0

Owner

pisi commented Nov 5, 2013

Released today as part of v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment