-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility of a closing animation #90
Comments
…e time instance is animated when played. #90
…calculates how many times to tick until it should stop. Number is stored in `"ticks"` data. #90
Ok, so at the end I've implemented one new option - Already merged into the development branch for release in version 1.3. |
Released today as part of v1.3.0 |
@IsraelThompson had a nice idea of having also a closing animation to complement the opening one in #49. He had some problems implementing it and might have had tapped a bug. But interesting idea indeed, let's discuss it, shall we.
Having a closing animation would expand the options API with:
opening
option,speed
.All very nice. But I'm not sure about the usage scenarios. With the
speed
,opening
andentry
options , Reel already empowers you with two independent phases of animation, which both can reel in opposite directions. The first phase limited in duration and the second phase being a neverending self-resuming spin. From my point of view, by adding the closing, instead of having one duration-limited and one unlimited, we would be having three duration-limited phases.That may look like a gain, but it's an overkill I'm afraid. What I recon instead in this issue is a need to define some sort of limit of how long the regular animation can play at once after
"play"
has been triggered. So that we can make the second animation phase duration-limited.Or do we really need 3 phases when there are only 2 possible directions of playback?
The text was updated successfully, but these errors were encountered: