This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Multiple fixes iOS 13.4 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oooooh a PR, nice. Ill try my best to take a look at this soon.
Sent From A Very Small Keyboard
… Le 31 mars 2020 à 16:49, tomquist ***@***.***> a écrit :
Swizzle all methods instead of overriding them in
categories which requires defined loading order.
This fixes most of the tests in iOS 13.4
You can view, comment on, or merge this pull request online at:
#210
Commit Summary
Multiple fixes iOS 13.4
File Changes
M UIKit/Spec/Stubs/UIViewControllerSpec+Spec.mm (6)
M UIKit/SpecHelper/Extensions/UITableViewCell+Spec.m (4)
M UIKit/SpecHelper/Stubs/UIAlertController+Spec.m (8)
M UIKit/SpecHelper/Stubs/UIApplication+Spec.m (4)
M UIKit/SpecHelper/Stubs/UINavigationController+Spec.m (11)
M UIKit/SpecHelper/Stubs/iOS/UIActionSheet+Spec.m (16)
M UIKit/SpecHelper/Stubs/iOS/UIAlertView+Spec.m (11)
M UIKit/SpecHelper/Stubs/iOS/UIImagePickerController+Spec.h (2)
M UIKit/SpecHelper/Stubs/iOS/UIImagePickerController+Spec.m (16)
M UIKit/SpecHelper/Stubs/iOS/UIWebView+Spec.m (22)
M UIKit/SpecHelper/Support/PCKMethodRedirector.h (2)
M UIKit/SpecHelper/Support/PCKMethodRedirector.m (34)
Patch Links:
https://github.com/pivotal-legacy/PivotalCoreKit/pull/210.patch
https://github.com/pivotal-legacy/PivotalCoreKit/pull/210.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
haha I had the same thought -- thanks so much for the PR @tomquist , these sound like much-needed updates to keep the libraries reliably useful |
tomquist
force-pushed
the
ios-13.4-adjustments
branch
3 times, most recently
from
ee5520d to
66929fa
Compare
Swizzle all methods instead of overriding them in categories which requires defined loading order. This fixes most of the tests in iOS 13.4
tomquist
force-pushed
the
ios-13.4-adjustments
branch
from
66929fa to
6654520
Compare
|
Thanks again for your PR @tomquist. I noticed that a few other specs were failing, namely the UITableViewCell specs related tapping to the delete accessory. Were those failing for you as well ? I tried to see what was causing that, but didn't see anything obvious. |
|
Unfortunately these were the only specs I could get to pass again. The reason for them to fail is that tapping the delete button doesn't have an effect anymore. I investigated quite some time to find out what is going on even by looking at the disassembly of UIKit using Hopper but without success. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swizzle all methods instead of overriding them in
categories which requires defined loading order.
This fixes most of the tests in iOS 13.4