Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Contrast results #19

Merged
merged 12 commits into from
May 30, 2024

Conversation

JesusCotlamee
Copy link
Contributor

Support for downloading Contrast results has been added. These results will be uploaded to Pixee. You can review the request at the following link #16.

Evidence:
Check action https://github.com/JesusCotlamee/pixeebot-test-pull-request-response/actions/runs/9219736706

Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
@JesusCotlamee JesusCotlamee requested a review from fjpgtt May 24, 2024 06:37
README.md Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
Refs: add-support-for-contrast-results
@JesusCotlamee JesusCotlamee requested a review from fjpgtt May 27, 2024 17:07
src/action.ts Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
Refs: add-support-for-contrast-results
@JesusCotlamee JesusCotlamee requested a review from fjpgtt May 27, 2024 20:25
@JesusCotlamee JesusCotlamee requested review from nahsra and ryandens May 27, 2024 21:34
@nahsra nahsra requested review from drdavella and removed request for nahsra May 28, 2024 01:11
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall. The main substantive comment is that the new Contrast fields cannot be marked as required in the action.yml file.

action.yml Outdated Show resolved Hide resolved
src/action.ts Outdated Show resolved Hide resolved
Refs: add-support-for-contrast-results
@JesusCotlamee JesusCotlamee requested a review from drdavella May 29, 2024 18:45
@JesusCotlamee JesusCotlamee merged commit f41a17c into main May 30, 2024
1 check passed
@JesusCotlamee JesusCotlamee deleted the add-support-for-contrast-results branch May 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants