Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Document SonarQube Integration #25

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Conversation

gilday
Copy link
Contributor

@gilday gilday commented Jun 5, 2024

SonarQube integration is significantly different vs SonarCloud integration, so we should have a new section for how to use this action with SonarQube.

gilday added 3 commits June 5, 2024 14:38
Where appropriate, qualify our use of "Sonar" as "SonarCloud", when we are giving instructions that would not apply to SonarQube.
SonarQube integration is significantly different vs SonarCloud integration.
@gilday gilday marked this pull request as ready for review June 5, 2024 19:25
@gilday gilday requested review from nahsra and drdavella June 5, 2024 19:25
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some nitpicky comments about wording. Feel free to take or leave.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
gilday and others added 2 commits June 5, 2024 16:09
Co-authored-by: Dan D'Avella <dan.davella@pixee.ai>
Signed-off-by: Johnathan Gilday <me@johnathangilday.com>
"Recommend" implies the second person, but we should prefer to use it explicitly.
@gilday gilday force-pushed the iss-1328/sonarqube-example branch from 12931a5 to 40a5bfd Compare June 5, 2024 20:14
README.md Outdated Show resolved Hide resolved
remove comma

Co-authored-by: Dan D'Avella <dan.davella@pixee.ai>
Signed-off-by: Johnathan Gilday <me@johnathangilday.com>
@gilday gilday merged commit 157c02a into main Jun 6, 2024
1 check passed
@gilday gilday deleted the iss-1328/sonarqube-example branch June 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants