-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISS-552 Supports workflow dispatch action event #6
ISS-552 Supports workflow dispatch action event #6
Conversation
Refs: ISS-552-supports-workflow-dispatch-actions-events
Refs: ISS-552-supports-workflow-dispatch-actions-events
Refs: ISS-552-supports-workflow-dispatch-actions-events
Refs: ISS-552-supports-workflow-dispatch-actions-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the examples of the workflows runs adnt he PR created in those cases?
Refs: ISS-552-supports-workflow-dispatch-actions-events
Can you add the links to workflow rusn where you show that it still works for the other types and the dispatch now works also |
Refs: ISS-552-supports-workflow-dispatch-actions-events
Of course, updated pull request description |
Refs: ISS-552-supports-workflow-dispatch-actions-events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only check my comment
Refs: ISS-552-supports-workflow-dispatch-actions-events
Recall that the scope of ISS-552 is limited to just the file upload. That's all we need from workflow_dispatch to workaround a weird demo scenario.
I'd be happy to stash the PR trigger logic in a branch, but I'm leaning towards not merging it until we have a use case for it. @ryandens does that make sense to you too? |
Refs: ISS-552-supports-workflow-dispatch-actions-events
Refs: ISS-552-supports-workflow-dispatch-actions-events
Refs: ISS-552-supports-workflow-dispatch-actions-events
The pixee/upload-tool-results-action has been updated to support the workflow_dispatch event in addition to the existing check_run and pull_request events.
Please note that the action will not trigger PR analysis for workflow_dispatch events. Instead, it will solely handle the upload of the specified tool results file provided through the file input. Additionally, it will initiate the analysis trigger for the uploaded file.
After reviewing the push event, it may not be necessary for SonarCloud, as SonarCloud is triggered when pushing and finishes between the check_run (already supported by the pixee action). However, it might be an option to implement it when the analysis is different from SonarCloud, for example, Semgrep. But before running the pixee action, we would need something that creates the file and passes it in the
file
property.Evidence
You can review the following pull request. The first suggestion is created upon the completion of SonarCloud by the check_run event, while the second suggestion is created by the workflow dispatch event