Optimize first painting of image #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load window and document dimensions when script is loaded, because they are available before DOM
| Parallax.requestRender(); | ||
| }); | ||
|
|
||
| loadDimensions(); | ||
| loadScrollPosition(); |
There was a problem hiding this comment.
could this not be achieved with a simple
$win.trigger('load.px.parallax');There was a problem hiding this comment.
I didn't want execute refresh and requestRender few more times as it would be when just triggering load.
wstoettinger
added a commit
to wstoettinger/parallax.js
that referenced
this pull request
Oct 1, 2015
This appends a whole DOM element to the parallax mirror (utilizing the same ".parallax-slider" class). so far it only works properly when setting the naturalWidth and naturalHeight options in the JS initialization. Somebody got a tip on how to improve that? I'm planning to implement a parallax carousel which should be possible with that change. also performance improvement suggestions from pixelcog#71
|
this is included in #88 which got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load window and document dimensions when script is loaded, because they are available before DOM.
Now we load this variables when window is fully loaded (
$win.on('load')) and callrequestRender. But in Parallax constructor we use another trigger to callingrequestRender: onload of mirrors image (this.$slider.one('load')).The second event fired before the first. This is the reason of wrong calculation of
top.