Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify set2ascii to provide correct tau values. #72

Closed
ksmith0 opened this issue Sep 7, 2016 · 1 comment
Closed

Modify set2ascii to provide correct tau values. #72

ksmith0 opened this issue Sep 7, 2016 · 1 comment
Labels
bug

Comments

@ksmith0
Copy link
Contributor

ksmith0 commented Sep 7, 2016

The TAU value is stored in the set file as an IEEE standard. We are incorrectly treating it in set2ascii.

Hi Mitch,

Stan is correct and you also figured it out already: the preamp tau has the IEEE standard format. The reason for that is we need to store it in the format which allows decimal fractions, e.g. 46.25 us. The only other number that has the same IEEE format is the baseline values in the list mode data, since the baseline can have decimal factions too.

Regards,
Hui
@ksmith0 ksmith0 added the bug label Sep 7, 2016
@spaulaus spaulaus mentioned this issue Jan 31, 2017
Merged
@spaulaus
Copy link
Member

spaulaus commented Feb 1, 2017

This also occurs in the data decoding of the Baseline value.

spaulaus added a commit that referenced this issue Feb 1, 2017
@spaulaus
Resolves #72
d58d7aa 
We added a method to convert from IEEE Floating point standard number to human readable decimal number. Added a unit test for this funciton, and fixed the ouput in set2ascii. We did this so that we could use these number in calculations, and verfications of settings.
ksmith0 pushed a commit that referenced this issue Feb 1, 2017
@spaulaus @ksmith0
Resolves #72
976d769 
We added a method to convert from IEEE Floating point standard number to human readable decimal number. Added a unit test for this funciton, and fixed the ouput in set2ascii. We did this so that we could use these number in calculations, and verfications of settings.
@ksmith0 ksmith0 closed this as completed Feb 3, 2017
spaulaus added a commit that referenced this issue Jun 7, 2017
@spaulaus
Resolves #72
f71e5b7 
We added a method to convert from IEEE Floating point standard number to human readable decimal number. Added a unit test for this funciton, and fixed the ouput in set2ascii. We did this so that we could use these number in calculations, and verfications of settings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spaulaus @ksmith0