Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ed25519 algorithm for signing #11

Closed
amyramos opened this issue Jan 16, 2021 · 1 comment · Fixed by #12
Closed

Add Ed25519 algorithm for signing #11

amyramos opened this issue Jan 16, 2021 · 1 comment · Fixed by #12
Assignees
@amyramos
Labels
enhancement New feature or request
Milestone
v. 1.0.0

Comments

@amyramos
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We should add more algorithms for signing, so Ed25519 is a great choice for extension.

Describe the solution you'd like
We can simply add Ed25519 structure interfacing with SignatureAlgorithm interface implementing Ed25519 algorithm.
@amyramos amyramos added the enhancement New feature or request label Jan 16, 2021
@amyramos
Copy link
Contributor Author

@pkosilo, I'd like to work on it myself too.

@pkasila pkasila added this to the v. 0.2.0 milestone Jan 16, 2021
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
feat: add Ed25519 signing algorithm
5363725 
implements pkasila#11
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
feat: add Ed25519 signing algorithm
39c9a32 
implements pkasila#11
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
test: add tests for ECDSA and Ed25519 helpers
02a8730 
some tests for features in pkasila#8, pkasila#11
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
test: update tests for ECDSA and Ed25519
b661ede 
updated tests for pkasila#8 and pkasila#11
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
test: add more tests for ECDSA and Ed25519 and update previously adde…
d25ff3b 
…d tests

add and update tests for ECDSA and Ed25519 signing algorithms (pkasila#8 and pkasila#11)
amyramos added a commit to amyramos/gorm-crypto that referenced this issue Jan 16, 2021
@amyramos
test: update tests (pkasila#8 and pkasila#11)
339f1bc 
updated tests for pkasila#8 and pkasila#11
@amyramos amyramos mentioned this issue Jan 16, 2021
Merged
@pkasila pkasila linked a pull request Jan 16, 2021 that will close this issue
Signing: Ed25519 and tests #12
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amyramos amyramos

Labels
enhancement New feature or request
Projects
None yet
Milestone
v. 1.0.0
Development

Successfully merging a pull request may close this issue.

Signing: Ed25519 and tests amyramos/gorm-crypto
2 participants
@pkasila @amyramos